Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple definition support for languages other than english. #25

Closed
meetDeveloper opened this issue Dec 7, 2018 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@meetDeveloper
Copy link
Owner

meetDeveloper commented Dec 7, 2018

I have finally added multiple definitions feature. If you google suppose define set, it will give you many definitions, I till now only used the first definition it provided, but now instead of first I show every definition. Thanks to @ScottEnock for suggesting the feature #5 and @martin-martin and @roaugusto for giving me motivation to do it finally #23 . I apologise for implementing it so late. It is a very useful feature, life caught me and I was not able to commit whole time to implement it.

Coming to developers who uses this API, you only have to change single line of code, and and I am giving array now, which contains multiple sets of definitions, earlier I was giving only the first set of definition, so if you want first set you only have to select first object from the array, and nothing else would be changed.

I am attaching the images to tell what I mean by multiple sets of definitions.

Thank you for your continuous support.

capture
capture2

@meetDeveloper meetDeveloper self-assigned this Dec 7, 2018
@meetDeveloper meetDeveloper added enhancement New feature or request help wanted Extra attention is needed labels Dec 7, 2018
@kovinet
Copy link

kovinet commented Mar 15, 2019

I have tested multiple definitions for Turkish language and they don't seem to work.

For example word 'ay', on Google the result is following:

image

but API returns only the first definition:

{
    "word": "ay",
    "meaning": {
        "

": [
            {
                "definition": "birdenbire duyumsanan ağrı ya da acıyı anlatır.",
                "example": "Ay, ölüyorum!"
            },
            {
                "definition": "türlü coşkusal duyguları anlatır.",
                "example": "Ay, ne güzel bir çocuk!"
            }
        ]
    }
}

Are multiple definitions supported only for English?

@meetDeveloper
Copy link
Owner Author

@kovinet You got it right, I have implemented that for english only currently, will update for other languages soon.

@TheMode
Copy link

TheMode commented Apr 21, 2019

Waiting for multi-language support :)

@meetDeveloper
Copy link
Owner Author

@TheMode Life is getting me, some work load, will surely get this done in upcoming weekend.

@meetDeveloper meetDeveloper changed the title I have added multiple definitions feature. Kindly update your app to support. Multiple definition support for languages other than english. May 28, 2019
@meetDeveloper
Copy link
Owner Author

@kovinet @TheMode Have implemented it, can you see if that is what you wanted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants