Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty JSEP in json causing validation error when jsep not required #38

Closed
awsmsrc opened this issue Jun 25, 2014 · 2 comments
Closed

Empty JSEP in json causing validation error when jsep not required #38

awsmsrc opened this issue Jun 25, 2014 · 2 comments

Comments

@awsmsrc
Copy link

awsmsrc commented Jun 25, 2014

Our JSON encoder was sending an empty JSEP when subscribing to a stream

We have made our encoder smarter andnot included the empty key but I imagine people will have a generic janus Message type that has a jsep

There is no need to validate the jsep if it is not used

OR

document that you MUST not send it

cheers

@lminiero
Copy link
Member

Good point, thanks, I'll update the docs accordingly.

@lminiero
Copy link
Member

lminiero commented Jul 1, 2014

Clarified in the updated docs.

@lminiero lminiero closed this as completed Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants