Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip uninstall removes "/var/*" #55

Closed
ushkinaz opened this issue Jun 27, 2013 · 13 comments
Closed

pip uninstall removes "/var/*" #55

ushkinaz opened this issue Jun 27, 2013 · 13 comments

Comments

@ushkinaz
Copy link

This is kinda critical.

I installed the plugin, then decided to reinstall it. Soon after the host I was doing it on collapsed.
Investigating the issue uncovered that "pip uninstall" removed everything under "/var"
See screenshot screenshot from 2013-06-27 22 02 37

@gmr
Copy link
Contributor

gmr commented Jun 27, 2013

What version of pip? This is pretty strange, I've not run into it.

@ushkinaz
Copy link
Author

centos 6.4
python 2.6.5
pip 1.3.1

@ushkinaz
Copy link
Author

distribute 0.6.45

@gmr
Copy link
Contributor

gmr commented Jun 27, 2013

Thanks, I'll try and replicate.

@ushkinaz
Copy link
Author

Another bit of extra info, installed-files.txt for egg has following content:
screenshot from 2013-06-27 23 22 56
Sorry for screenshots and not text, our extra-paranoid sysadmin unplugged that host from network, and I'm only able to take screenshots from VMWare console.

@ccooper21
Copy link
Contributor

My team has encountered this same issue and unfortunately lost three servers in the process.

In trying to investigate further, I found this issue raised against the "pip" project apparently describing the same problem. The issue was subsequently passed off to the "distribute" project by raising this issue, which is still open.

Irrespective of whether the root cause of this problem is due to a defect in another project, it would be nice to make the necessary changes to this project such that others don't experience the same surprise. Apparently this is caused by empty file lists getting passed to the "data_files" argument of the "setup(...)" function called in the "setup.py" file.

For anyone who is interested, my fork contains a tentative fix for this issue. I have asked one of my team members to validate the fix. If all is well, I'll submit a pull request for the change.

@gmr
Copy link
Contributor

gmr commented Jul 9, 2013

I apologize for the trouble and appreciate the patch.

@gmr
Copy link
Contributor

gmr commented Jul 9, 2013

Can you submit this as a pull request please?

@ccooper21
Copy link
Contributor

No worries. The pull request has been submitted.

gmr pushed a commit that referenced this issue Jul 9, 2013
Fix for issue #55 where the "/var" directory was being deleted during uninstallation
@a13x212
Copy link

a13x212 commented Jul 15, 2013

When will this change be in a release? I just ran into the same issue.

@gmr
Copy link
Contributor

gmr commented Jul 18, 2013

1.0.13 will be "very soon"

@davidsteinsland
Copy link

Although this bug has been fixed, we'd appreciate some kind of warning. Thru NewRelic, you know who's got the plugin installed, and from there you should send out an alert. Today we just lost our production server, and has probably lost several hours of work (thank God for backups, at least).

Shame on you!

@gmr
Copy link
Contributor

gmr commented Aug 13, 2013

NewRelic did send a warning to every account that installed it. Sorry that you lost your server and the work involved to recover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants