InlineBlockList component #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akdetrick
reviewed
Mar 21, 2017
| } | ||
|
|
||
| &:after { | ||
| content: attr(data-separator); |
akdetrick
reviewed
Mar 21, 2017
| const { | ||
| className, | ||
| items, | ||
| separator, |
There was a problem hiding this comment.
love the flexibility here with separator
akdetrick
suggested changes
Mar 21, 2017
src/InlineBlockList.jsx
Outdated
| return ( | ||
| <ul | ||
| className={classNames} | ||
| {...other}> |
There was a problem hiding this comment.
minor code style thing - we've been wrapping the closing > to the next line for readability
src/inlineBlockList.story.jsx
Outdated
| () => ( | ||
| <InfoWrapper> | ||
| <InlineBlockList | ||
| style={{padding: '20px'}} |
There was a problem hiding this comment.
I'd prefer to import a Section & Chunk here to an inline style. Showing layout components in the examples (even if they're unrelated to InlineBlockList) seems like it would be helpful
…sts because I fucking can
akdetrick
reviewed
Mar 21, 2017
src/inlineBlockList.test.jsx
Outdated
| @@ -18,7 +18,7 @@ const ITEMS = [ | |||
| '日本語', | |||
| '한국어', | |||
| ], | |||
| SEPARATOR = '·'; | |||
| SEPARATOR = '☃'; | |||
akdetrick
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Needed for header and footer navigation redesign for replatform
Description
Takes an array of text strings or elements and creates a list that is displayed inline
Screenshots (if applicable)