Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16-bit branch (target out of bounds) Ophis #19

Closed
Ben-401 opened this issue Sep 8, 2016 · 6 comments
Closed

16-bit branch (target out of bounds) Ophis #19

Ben-401 opened this issue Sep 8, 2016 · 6 comments
Labels

Comments

@Ben-401
Copy link
Contributor

Ben-401 commented Sep 8, 2016

in kickstart_dos, PGS has previously experienced:

    ; XXX - 16 bit BNE should be fine here! Why doesn't it work?
    ;   bne partitionerror
    beq ddop11ok
    jmp partitionerror
ddop11ok:

Now I have experienced this too.

    lda [sd_sectorbuffer+$1FF]  
    cmp #$AA
    bne partitionerror

fails because function "partitionerror" seems out of bounds.

SO: Why doesnt this instruction get converted properly by Ophis to the 16-bit branch like other detected branches?

@gardners
Copy link
Contributor

gardners commented Sep 8, 2016

Hello,

A fine question, and one that is best solved by us moving to ca-65 instead
of Ophis, now that ca-65 has 4510 support.

Paul.

On Thu, Sep 8, 2016 at 12:23 PM, Ben-401 notifications@github.com wrote:

in kickstart_dos, PGS has previously experienced:

; XXX - 16 bit BNE should be fine here! Why doesn't it work?
; bne partitionerror
beq ddop11ok
jmp partitionerror

ddop11ok:

Now I have experienced this too.

lda [sd_sectorbuffer+$1FF]
cmp #$AA
bne partitionerror

fails because function "partitionerror" seems out of bounds.

SO: Why doesnt this instruction get converted properly by Ophis to the
16-bit branch like other detected branches?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#19, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAonT0rN4b-VoHknKXLr5iko0-rvQYcBks5qn3iwgaJpZM4J3j0k
.

@lgblgblgb
Copy link
Contributor

Wow! :) I forked cc65 some weeks ago to put 4510 support into ca65, but since it's kinda complex for my taste (maybe to my knowledge as well), I only did "simple" things so far, without dealing the 16 bit relative jumps too much and similar "minor" :) issues. Nice to hear that ca65 has "sane" 4510 support already then! I would vote for CA65 too, for many reasons. Just one note in general: it's important that even things like m65dbg (and my wannabe M65 emulation) currently uses list file produced by Ophis.

@gardners
Copy link
Contributor

gardners commented Sep 8, 2016

Hello,

Right, we need to make sure the m65dbg and anything else that depends on
Ophis is provided with the required patches to allow it to work. And we
must, of course, convert the kickstart and other programs from Ophis to
CA65 format. Not too hard on either front, I suspect.

Paul.

On Fri, Sep 9, 2016 at 1:07 AM, LGB notifications@github.com wrote:

Wow! :) I forked cc65 some weeks ago to put 4510 support into ca65, but
since it's kinda complex for my taste (maybe to my knowledge as well), I
only did "simple" things so far, without dealing the 16 bit relative jumps
too much and similar "minor" :) issues. Nice to hear that ca65 has "sane"
4510 support already then! I would vote for CA65 too, for many reasons.
Just one note in general: it's important that even things like m65dbg (and
my wannabe M65 emulation) currently uses list file produced by Ophis.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAonT-sOAlctq-G0tAs9CKvgUoRXG7zKks5qoCuxgaJpZM4J3j0k
.

@Ben-401
Copy link
Contributor Author

Ben-401 commented Sep 29, 2016

Sorry, but I suggest we stay with Ophis as we know it currently works, mostly.

@gardners
Copy link
Contributor

As discussed, we should move to cc65/ca65, so that everyone is using the
same tools for everything. ca65/cc65 has 4510 support now, thanks to Svolli
and others.

Paul.

On Thu, Sep 29, 2016 at 12:01 PM, Ben-401 notifications@github.com wrote:

Sorry, but I suggest we stay with Ophis as we know it currently works,
mostly.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAonTzHDeIMGNg6F33sKYxBQyhddFOjsks5quyLygaJpZM4J3j0k
.

@rdpeake rdpeake added the wontfix label Feb 5, 2021
@rdpeake
Copy link
Collaborator

rdpeake commented Feb 5, 2021

Ophis no longer in use

@rdpeake rdpeake closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants