Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom data management (for multiple tenant Kafka) #456

Merged
merged 5 commits into from Jan 13, 2022

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Jan 7, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #456 (597db54) into main (3fd2287) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   80.59%   80.56%   -0.04%     
==========================================
  Files          70       70              
  Lines        8154     8198      +44     
==========================================
+ Hits         6572     6605      +33     
- Misses       1225     1238      +13     
+ Partials      357      355       -2     
Impacted Files Coverage Δ
pkg/cluster/layout.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/cluster/syncer.go 76.28% <0.00%> (-1.29%) ⬇️
pkg/cluster/cluster.go 50.68% <0.00%> (-1.03%) ⬇️
pkg/object/mqttproxy/client.go 77.16% <0.00%> (-0.51%) ⬇️
pkg/filter/proxy/request.go 95.45% <0.00%> (+0.14%) ⬆️
pkg/cluster/config.go 89.07% <0.00%> (+0.18%) ⬆️
pkg/filter/proxy/server.go 73.54% <0.00%> (+2.95%) ⬆️
pkg/object/pipeline/mock.go 86.95% <0.00%> (+5.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd2287...597db54. Read the comment docs.

@localvar localvar marked this pull request as ready for review January 12, 2022 01:36
@haoel
Copy link
Contributor

haoel commented Jan 12, 2022

@localvar please add some documents for this feature.

@localvar
Copy link
Collaborator Author

This feature is ready for the requirement of multiple tenant Kafka now, but the idea of this feature is the same as the CustomResource feature in EaseMesh. So I will do a refactor to avoid code duplication, but this may introduce some changes, so I plan to write the document after the refactor, is this fine?

@haoel
Copy link
Contributor

haoel commented Jan 12, 2022

fine. you can include the documents in the refactor.

@samutamm samutamm merged commit 9b29b1c into easegress-io:main Jan 13, 2022
@localvar localvar deleted the custom-data branch February 6, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants