Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to build against ffmpeg 4.4 #578

Open
michojel opened this issue May 19, 2021 · 3 comments
Open

fails to build against ffmpeg 4.4 #578

michojel opened this issue May 19, 2021 · 3 comments

Comments

@michojel
Copy link

ffmpeg 4.4 made some fields private

MEGAsync tries to access them and fails to build:

mega/src/gfx/qt.cpp:1218:18: error: 'AVStream' {aka 'struct AVStream'} has no member named 'skip_to_keyframe'
 1218 |     videoStream->skip_to_keyframe = true;
      |                  ^~~~~~~~~~~~~~~~
@alkaris2
Copy link

alkaris2 commented Jul 3, 2021

Remove dependency ffmpeg3.4 and use ffmpeg 2:4.4-3 as using ffmpeg3.4 breaks dependencies as it relies on another package that is for older systems which causes issues when building on Arch.

https://aur.archlinux.org/packages/megasync

@mtorromeo
Copy link

The line can be removed and the compilation succeeds.

The previous line formatContext->seek2any = false is already telling ffmpeg to only seek to keyframes, skip_to_keyframe shouldn't be necessary.

@michojel
Copy link
Author

FWIW, on nixos we started building with this patch: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/megasync/ffmpeg_44.patch
Thanks to @mtorromeo for the hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants