Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Add command-line option to strip some of the "info" fields. #89

Closed
IAXES opened this issue Jan 19, 2017 · 3 comments
Closed

ER: Add command-line option to strip some of the "info" fields. #89

IAXES opened this issue Jan 19, 2017 · 3 comments

Comments

@IAXES
Copy link

IAXES commented Jan 19, 2017

Would there be any opposition to me filing a pull request for an extra option to filter some of the data included in the --info field that is included in the final output (ie: my_installer.run)? One thing I'd like to remove is the fields showing the full command used to generate the installer, which includes the full path to the source locations (ie: my home folder). I'd like to strip those out of "production" installers. In my case, I'd like to prevent the following from appearing in a production installer:

	echo Built with Makeself version 2.3.0 on 
	echo Build command was: "./makeself.sh \\
    \"/home/ford_prefect/installer\" \\
    \"/home/ford_prefect/installer.run\" \\
    \"42\" \\
    \"./42.sh\""
@megastep
Copy link
Owner

No objection from me, feel free!

@wjlester
Copy link

Was something like this ever merged? Recent updates include sensitive data in the --info command such as GPG and SSL passphrases. It seems as if it would be appropriate to omit the "Build command was:" line in makeself-header.sh until a sanitized version can be displayed.

@megastep
Copy link
Owner

I don't remember seeing a pull request for this and it's quite possible it was closed without it being proposed. However I'd be OK with having a command-line option to makeself to prevent the build command from being stored in the archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants