Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type in argparse #90

Closed
tankeco opened this issue Jan 28, 2021 · 0 comments · Fixed by #91
Closed

add type in argparse #90

tankeco opened this issue Jan 28, 2021 · 0 comments · Fixed by #91
Assignees
@zhouyizhuang-megvii

Comments

@tankeco
Copy link

tankeco commented Jan 28, 2021 •
edited
Loading

环境

1.系统环境：ubuntu
2.MegEngine版本：1.2.0
3.python版本：3.6
4.模型名称：/

复现步骤

  1. python3 train.py --arch resnet50 --batch-size 32 --learning-rate 0.025 --ngpus 8 --save .

请提供关键的代码片段便于追查问题

https://github.com/MegEngine/Models/blob/master/official/vision/classification/resnet/train.py#L58

The default type of argparse is str, so once batch_size, learning_rate or world_size is modified, it will cause an error
zhouyizhuang-megvii added a commit to zhouyizhuang-megvii/Models that referenced this issue Jan 28, 2021
@zhouyizhuang-megvii
fix(classification): add default type in argparse
a88b58f 
resolve MegEngine#90

also fix a bug that Server would be unexpectedly recycled.
@zhouyizhuang-megvii zhouyizhuang-megvii mentioned this issue Jan 28, 2021
Merged
FateScript pushed a commit that referenced this issue Jan 29, 2021
@zhouyizhuang-megvii
fix(classification): add default type in argparse (#91)
924d3b8 
* fix(classification): add default type in argparse

resolve #90

also fix a bug that Server would be unexpectedly recycled.

* fix(ci): ignore tokenization import-error, and flake8 unused error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyizhuang-megvii zhouyizhuang-megvii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(classification): add default type in argparse zhouyizhuang-megvii/Models
2 participants
@tankeco @zhouyizhuang-megvii