Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The dataset sampler during single GPU training should be infinite #19

Closed
zizizihua opened this issue Jul 20, 2021 · 0 comments · Fixed by #22
Closed

bug: The dataset sampler during single GPU training should be infinite #19

zizizihua opened this issue Jul 20, 2021 · 0 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@zizizihua
Copy link

In yolox/exp/yolo_base.py:122

if is_distributed:
    batch_size = batch_size // dist.get_world_size()
    sampler = InfiniteSampler(
        len(self.dataset), seed=self.seed if self.seed else 0
    )
else:
    sampler = torch.utils.data.RandomSampler(self.dataset)

torch.utils.data.RandomSampler is not infinite, and will cause exception after an epoch of training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants