Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some feedback of demo #1

Closed
ssmem opened this issue Dec 6, 2021 · 1 comment
Closed

some feedback of demo #1

ssmem opened this issue Dec 6, 2021 · 1 comment

Comments

@ssmem
Copy link

ssmem commented Dec 6, 2021

Hello, I tried your demo of BAL_Double.
I have 2 questions of it.

  1. The program will take 100% of my cpu even I have no data (Venice). There is no strategy of data checking.
  2. The program will take 100% of my cpu when I input params world_size==2. But I have only 1 gpu. The program stay at that progress and use my cpu. When I input right gpu number of 1, the program solved problem very fast.
    Finally, I suggest the program should more robust of the main progress. For example, some checking and logs let us know what happened. And I also want to know why it take all of my cpu when nothing to solve.
    Many thanks for watching that! Your work is pretty well that compared with ceres. I think there are still some small problem to solve on the level of program.
@JieRen98
Copy link
Collaborator

JieRen98 commented Dec 7, 2021

Thank you for your interest in MegBA.

The CPU 100% computation is due to https://github.com/MegviiRobot/MegBA/blob/main/src/resource/Manager.cpp#L19. It blocks the main thread until all devices return.

We will continue to make MegBA more robust, e.g., adding more exception throws and log messages to help the user with easier debugging.

@JieRen98 JieRen98 closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants