feat(all): allow build on windows/linux #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RamadanAhmed
commented
Jun 11, 2022
RamadanAhmed
commented
- Upgrade CMake to use find(CUDAToolkit) instead of deprecated find(CUDA)
- Add CMakePresets
- Remove .gitmodules
- Add vcpkg.json to mange third_party packages
- Add libraryConfig.cmake.in for library installation
- Add CMake artifact to .gitignore
RamadanAhmed
force-pushed
the
windows-build
branch
from
0ceae93
to
3016efe
Compare
RamadanAhmed
changed the title
RamadanAhmed
force-pushed
the
windows-build
branch
from
3016efe
to
20b6410
Compare
RamadanAhmed
changed the title
- Upgrade CMake to use find(CUDAToolkit) instead of deprecated find(CUDA) - Add CMakePresets - Remove .gitmodules - Add vcpkg.json to mange third_party packages - Add libraryConfig.cmake.in for library installation - Add CMake artifact to .gitignore
RamadanAhmed
force-pushed
the
windows-build
branch
from
20b6410
to
eec0dbb
Compare
|
Sorry for the late reply, nice job! I noticed you remove the third-party Eigen by using find_package, but MegBA currently relies on Eigen 3.4, I am afraid users have difficulties in version choosing by using find_package. Jie |
|
I provided vcpkg.json that manage 3-rd party libs it already contain Eigen 3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.