Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vip list group #730

Open
3 of 5 tasks
Riverlance opened this issue Mar 26, 2024 · 2 comments
Open
3 of 5 tasks

Vip list group #730

Riverlance opened this issue Mar 26, 2024 · 2 comments
Labels
Type: Enhancement New feature or request

Comments

@Riverlance
Copy link
Contributor

Priority

Missing Content

Area

  • Data
  • Source
  • Docker
  • Other

What is missing?

image

The feature Otc::GameVipGroups is not implemented, as shown below:

image
image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions github-actions bot added the Status: Pending Test This PR or Issue requires more testing label Mar 26, 2024
@luanluciano93
Copy link
Collaborator

Can you explain better? the feature is automatically activated in versions 12+

g_game.enableFeature(GameVipGroups);

@Riverlance
Copy link
Contributor Author

Riverlance commented Mar 28, 2024

Can you explain better? the feature is automatically activated in versions 12+

g_game.enableFeature(GameVipGroups);

Sure.
It is activated indeed, although it is not implemented.

When you write lines like:

msg->getU8(); // Group ID
msg->getString(); // Group name
msg->getU8(); // Can edit group? (bool)

You are receiving data from server about vip groups, but doing nothing with them.
You need to assign them to variables, then use into a function that should pass through a Lua callback which will implement the visual of groups on Vip List mini window.
See id, name, status, desc, iconId, notifyLogin used on g_game.processVipAdd to see how it should be done.


  1. The correct would be something like myVariable = msg->getU8();, not just msg->getU8(); without signing it to a variable nor using it.
  2. And then using myVariable in g_game.processVipAdd (in case of ProtocolGame::parseVipAdd) or in g_game.processVipStateChange (in case of ProtocolGame::parseVipLogout).
  3. Finally, it should be implemented on Lua in g_game.onAddVip (in case of g_game.processVipAdd) or in g_game.onVipStateChange (in case of g_game.processVipStateChange).
  4. Once you have the data about groups on Vip List mini window Lua module, you can use it to implement the visual in this mini window.

@luanluciano93 luanluciano93 added Type: Enhancement New feature or request and removed Status: Pending Test This PR or Issue requires more testing labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants