Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use conditional sound libs for compiling on newer linux distros #781

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tornadia
Copy link

Description

Fixes compiling on Ubuntu with disabled sound

Behavior

Actual

Doesnt compile if sound is used

Expected

Makes it possible to disable sound again

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah
Copy link
Owner

mehah commented Jun 3, 2024

@tornadia
build is broken.

@mehah
Copy link
Owner

mehah commented Jun 10, 2024

@tornadia
which has leading or trailing whitespace. This is
now an error according to policy CMP0004.

Will this fix the pipeline issues? No idea! But I sure hope so :D
@mehah
Copy link
Owner

mehah commented Jun 27, 2024

@tornadia
Copy link
Author

tornadia commented Jul 3, 2024

@tornadia https://github.com/mehah/otclient/actions/runs/9700179052/job/26783002143?pr=781#step:8:371

Hi Mehah! I appreciate your thorough reviews to push this effort further and get it merged. I am planning to resolve the issue by removing the quotation marks and maybe separating the setters into different lines further if that doesn't work. In my local environment it is working fine. Can you suggest an approach to resolve this?

@mehah
Copy link
Owner

mehah commented Jul 4, 2024

@tornadia
From what I understand, these errors are syntax errors, I'll see if @dudantas or @beats-dh can help you.

@majestyotbr majestyotbr changed the title [PR#753][buildsystem]: Use conditional sound libs for compiling on newer linux distros build: use conditional sound libs for compiling on newer linux distros Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux Compile Issue
2 participants