Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching projects breaks find-and-replace:select-next #98

Open
fredrikekelund opened this issue Jul 4, 2017 · 10 comments
Open

Switching projects breaks find-and-replace:select-next #98

fredrikekelund opened this issue Jul 4, 2017 · 10 comments

Comments

@fredrikekelund
Copy link

I've seen #95 and I've given project-manager a spin, but what I want is just a quick way of switching workspace, and manually handling projects in project-manager is tedious, so I came back to project-plus. I hope you haven't deprecated it completely just yet.

The issue at hand is the fact that every time I switch projects, the find-and-replace:select-next command increases the number of occurences it selects by 1. Example: if I have highlighted the word Section and click Cmd-d, then I expect only the next occurence of Section to be highlighted as well. But after having switched projects once, the next two occurences of Section are highlighted. After having switched projects twice, the next three occurences are highlighted. And so on...

@McSodbrenner
Copy link

The same for me. And the same reasons why I cannot switch.

btw: project-manager does have the same issue:
https://github.com/danielbrodin/atom-project-manager/issues/339

@fredrikekelund
Copy link
Author

Could these lines in atom-project-util be the culprit?

@mehcode
Copy link
Owner

mehcode commented Jul 5, 2017

I've seen #95 and I've given project-manager a spin, but what I want is just a quick way of switching workspace, and manually handling projects in project-manager is tedious, so I came back to project-plus. I hope you haven't deprecated it completely just yet.

Project Manager does support Git project detection though it's not implemented correctly (it detects at start of the editor and not when you open the project finder so it causes slowdowns in atom).

See https://github.com/danielbrodin/atom-project-manager/issues/345


@fredrikekelund Those lines could be it. I don't remember why they needed to be hacked before. Probably should have added that to the comment.

@fredrikekelund
Copy link
Author

I'm not encountering this issues in Atom 1.19.0 anymore. Does it work for you as well, @McSodbrenner?

@fredrikekelund
Copy link
Author

Scratch my last comment, it looks like the bug is still present 😞

@xream
Copy link

xream commented Oct 26, 2017

fixed by reload find-and-replace https://atom.io/packages/project-neue

@aamederen
Copy link

I have started to encounter this problem. I am using Atom 1.24.0 and project-plus 1.0.0.

@jminuscula
Copy link

I'm also experiencing this issue with Atom 1.26.0 and macOS 10.13.4

Find and Replace work on new windows, but as soon as I change projects, the dialog stops showing up. Reloading the window fixes it.

@fredrikekelund
Copy link
Author

I'm experiencing the same issue as you @jminuscula. I've reported it in my previous issur atom/find-and-replace#950. We'll see if someone picks it up, otherwise I'll open a new issue

@jminuscula
Copy link

@fredrikekelund looks like this project is abandoned in favor ofatom-project-manager. I've been using it for a few days without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants