Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhereBetweenCondition fails if start or end is zero #126

Closed
elrasco opened this issue Nov 24, 2020 · 2 comments
Closed

WhereBetweenCondition fails if start or end is zero #126

elrasco opened this issue Nov 24, 2020 · 2 comments

Comments

@elrasco
Copy link

elrasco commented Nov 24, 2020

Describe the bug
In file eloquent-filter/src/QueryFilter/Detection/ConditionsDetect/WhereBetweenCondition.php the condition fails if start or end is zero

To Reproduce
Steps to reproduce the behavior:
Pass to method detect something like
array ( 'price' => array ( 'start' => 0, 'end' => 336, ) )

Expected behavior
detect returns WhereBetween::class

Actual behavior
detect return null

@mehdi-fathi
Copy link
Owner

@elrasco Thanks for the report. I fixed it. Please update the package to 2.3.8.

@elrasco
Copy link
Author

elrasco commented Nov 24, 2020

@mehdi-fathi thank you very much. It works now. super fast.

@elrasco elrasco closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants