Added a reconnect option #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a test to prevent reconnection after the WebSocket component is unmounted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ! I've added a "reconnect" option to the Websocket component.
How it's used :
<Websocket reconnect={10} debug={true} url='ws://localhost:8080/' onMessage={this.handleData}/>If disconnected, the component will wait between 0 and
10seconds before attempting a reconnection. The randomness avoids a storm of reconnections in case of server restart.I've tried using
ws.resume()instead of recreating the websocket entirely but it fails to work sometimes. Recreating the ws from scratch shows no ill effect.If reconnection fails, it will attempt a new reconnection later, and so on...
I tried to stick to your code conventions...