Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

たまにinboxがたまる #1016

Closed
mei23 opened this issue Apr 9, 2020 · 3 comments
Closed

たまにinboxがたまる #1016

mei23 opened this issue Apr 9, 2020 · 3 comments

Comments

@mei23
Copy link
Owner

mei23 commented Apr 9, 2020

💡 Summary

添付ファイルがあるのが溜まってたので
最近変えたnode-fetchのDLとかあやしい？

🙂 Expected Behavior

☹️ Actual Behavior

📝 Steps to Reproduce

📌 Environment
@mei23
Copy link
Owner Author

mei23 commented Apr 10, 2020

node-fetch版だとDLが途中でだんまりになった場合に、そのままだんまりになってしまう
request版だとそれはないが、#1020 は起きる

@mei23
Copy link
Owner Author

mei23 commented Apr 10, 2020 •
edited

requestは、head受信でもbody受信でもタイムアウトしてくれる
gotは、head受信でもbody受信でもタイムアウトしてくれる
superagentは、head受信でもbody受信でもタイムアウトしてくれる

@mei23
Copy link
Owner Author

mei23 commented Apr 10, 2020

fetch && stream && body receive timeout の場合に起きる
node-fetch/node-fetch#768 (comment)
Use AbortController とある

こうかしら
mei23/newreq@915517a#diff-960f70ff7aa2e460ea73b47b52de935b

@mei23 mei23 closed this as completed in 55c093a Apr 10, 2020
@mei23 mei23 mentioned this issue Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mei23