Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate auth service to trpc #288

Merged
merged 4 commits into from Jan 23, 2023
Merged

Conversation

meienberger
Copy link
Collaborator

@meienberger meienberger commented Dec 26, 2022

Following #284, migrating auth services to tRPC, Next and Prisma

Changes

  • Setup Prisma to use the existing db
  • Move and create tRPC routes for auth services
  • Refactor client-side to use new tRPC queries/mutations
  • Refactor server to remove useless graphql resolvers

@meienberger meienberger changed the title Feat/auth service trpc refactor: migrate auth service to trpc Dec 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Base: 85.82% // Head: 85.08% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (afae393) compared to base (92c1a76).
Patch coverage: 79.81% of modified lines in pull request are covered.

❗ Current head afae393 differs from pull request most recent head d374c3f. Consider uploading reports for the commit d374c3f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #288      +/-   ##
===========================================
- Coverage    85.82%   85.08%   -0.74%     
===========================================
  Files          109      110       +1     
  Lines         2250     2193      -57     
  Branches       385      374      -11     
===========================================
- Hits          1931     1866      -65     
- Misses         307      315       +8     
  Partials        12       12              
Impacted Files Coverage Δ
...ackages/dashboard/src/client/generated/graphql.tsx 82.35% <ø> (+3.78%) ⬆️
packages/dashboard/src/server/context.ts 0.00% <0.00%> (ø)
...ackages/dashboard/src/server/core/Logger/Logger.ts 0.00% <0.00%> (ø)
packages/dashboard/src/server/routers/_app.ts 0.00% <0.00%> (ø)
...s/dashboard/src/server/routers/auth/auth.router.ts 0.00% <0.00%> (ø)
...shboard/src/server/routers/system/system.router.ts 0.00% <ø> (ø)
packages/system-api/src/schema.ts 100.00% <ø> (ø)
packages/dashboard/src/client/utils/trpc.ts 29.41% <50.00%> (-1.84%) ⬇️
...dashboard/src/server/core/TipiConfig/TipiConfig.ts 88.67% <60.00%> (-5.67%) ⬇️
...dashboard/src/server/services/auth/auth.service.ts 96.49% <87.50%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger force-pushed the feat/auth-service-trpc branch 3 times, most recently from 8c74600 to 041c1f9 Compare December 28, 2022 07:48
Base automatically changed from feat/poc-trpc to develop January 23, 2023 19:04
@meienberger meienberger marked this pull request as ready for review January 23, 2023 19:06
@meienberger meienberger force-pushed the feat/auth-service-trpc branch 2 times, most recently from 17c44da to afae393 Compare January 23, 2023 19:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meienberger meienberger merged commit 4609078 into develop Jan 23, 2023
@meienberger meienberger deleted the feat/auth-service-trpc branch January 23, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants