Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: native postgres migrations #290

Merged
merged 4 commits into from Jan 23, 2023

Conversation

meienberger
Copy link
Collaborator

Purpose

With the recent move from typeorm to prisma, the migrations can not be run anymore. This PR is de-coupling the ORM from the migration process to not be locked again in the future. All previous migrations have been re-written in plain .sql files to be run natively.

Changes

  • Migrated typeorm migrations to native sql.
  • Created a script to load before server start and run the migrations.
  • Refactor code to not use typeorm for migrations anymore
  • Delete previously created prisma migrations

@meienberger meienberger force-pushed the refactor/native-postgres-migrations branch from 2115a45 to 2ee21e1 Compare December 28, 2022 20:56
@codecov-commenter
Copy link

Codecov Report

Base: 85.08% // Head: 85.28% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (2ee21e1) compared to base (041c1f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/auth-service-trpc     #290      +/-   ##
==========================================================
+ Coverage                   85.08%   85.28%   +0.19%     
==========================================================
  Files                         110      110              
  Lines                        2193     2188       -5     
  Branches                      374      374              
==========================================================
  Hits                         1866     1866              
+ Misses                        315      310       -5     
  Partials                       12       12              
Impacted Files Coverage Δ
packages/system-api/src/server.ts 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger force-pushed the refactor/native-postgres-migrations branch from 2ee21e1 to 0ba3a49 Compare January 23, 2023 18:58
@meienberger meienberger force-pushed the feat/auth-service-trpc branch 4 times, most recently from afae393 to d374c3f Compare January 23, 2023 19:36
@meienberger meienberger changed the title Refactor/native postgres migrations refactor: native postgres migrations Jan 23, 2023
Base automatically changed from feat/auth-service-trpc to develop January 23, 2023 19:42
@meienberger meienberger force-pushed the refactor/native-postgres-migrations branch from 0ba3a49 to 873a53f Compare January 23, 2023 19:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meienberger meienberger merged commit 71d106b into develop Jan 23, 2023
@meienberger meienberger deleted the refactor/native-postgres-migrations branch January 23, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants