Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cookie based session #376

Merged
merged 6 commits into from
May 5, 2023
Merged

Conversation

meienberger
Copy link
Collaborator

@meienberger meienberger commented May 3, 2023

Purpose

This pull request changed the auth mechanism from JWT to cookie-based session using express-session. This will unblock more server-side features like loading correct user language on first request

@meienberger meienberger self-assigned this May 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Patch coverage: 97.18% and project coverage change: +0.56 🎉

Comparison is base (e036382) 95.36% compared to head (eb5e8b2) 95.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #376      +/-   ##
===========================================
+ Coverage    95.36%   95.92%   +0.56%     
===========================================
  Files          103      104       +1     
  Lines         2263     2233      -30     
  Branches       379      370       -9     
===========================================
- Hits          2158     2142      -16     
+ Misses          98       86      -12     
+ Partials         7        5       -2     
Impacted Files Coverage Δ
src/client/components/ui/Header/Header.tsx 100.00% <ø> (ø)
...dules/Apps/pages/AppDetailsPage/AppDetailsPage.tsx 100.00% <ø> (+15.00%) ⬆️
...tings/containers/GeneralActions/GeneralActions.tsx 100.00% <ø> (ø)
src/client/utils/trpc.ts 30.76% <0.00%> (+1.35%) ⬆️
src/server/context.ts 0.00% <ø> (ø)
src/client/components/Layout/Layout.tsx 100.00% <100.00%> (ø)
.../Auth/containers/LoginContainer/LoginContainer.tsx 100.00% <100.00%> (ø)
...containers/RegisterContainer/RegisterContainer.tsx 100.00% <100.00%> (ø)
src/client/utils/page-helpers.ts 100.00% <100.00%> (ø)
src/server/core/TipiCache/TipiCache.ts 82.05% <100.00%> (-0.45%) ⬇️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger force-pushed the feat/cookie-based-session branch 3 times, most recently from 2d5551c to 66a1100 Compare May 5, 2023 18:40
@meienberger meienberger marked this pull request as ready for review May 5, 2023 18:45
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meienberger meienberger merged commit b7bb09a into develop May 5, 2023
8 checks passed
@meienberger meienberger deleted the feat/cookie-based-session branch May 5, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants