-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cookie based session #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meienberger
force-pushed
the
feat/cookie-based-session
branch
from
May 3, 2023 21:06
280108d
to
cdf89f6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #376 +/- ##
===========================================
+ Coverage 95.36% 95.92% +0.56%
===========================================
Files 103 104 +1
Lines 2263 2233 -30
Branches 379 370 -9
===========================================
- Hits 2158 2142 -16
+ Misses 98 86 -12
+ Partials 7 5 -2
☔ View full report in Codecov by Sentry. |
meienberger
force-pushed
the
feat/cookie-based-session
branch
3 times, most recently
from
May 5, 2023 18:40
2d5551c
to
66a1100
Compare
meienberger
force-pushed
the
feat/cookie-based-session
branch
from
May 5, 2023 19:18
66a1100
to
5108381
Compare
meienberger
force-pushed
the
feat/cookie-based-session
branch
from
May 5, 2023 20:10
eb5e8b2
to
5391443
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request changed the auth mechanism from JWT to cookie-based session using
express-session
. This will unblock more server-side features like loading correct user language on first request