Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app internationalization #379

Merged
merged 42 commits into from
May 9, 2023
Merged

Conversation

meienberger
Copy link
Collaborator

@meienberger meienberger commented May 6, 2023

Purpose

This pull request adds the base mechanism for internationalizing the app. The authentication flow has been adapted to use i18n

Changes

  • Add locale in user table
  • Create shared utils for locale detection
  • Setup next-intl

@meienberger meienberger self-assigned this May 6, 2023
@meienberger meienberger force-pushed the feat/internationalization branch 2 times, most recently from be95999 to fa45be3 Compare May 6, 2023 14:07
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 98.33% and project coverage change: +0.08 🎉

Comparison is base (acdeb0f) 95.92% compared to head (1e186c3) 96.01%.

❗ Current head 1e186c3 differs from pull request most recent head 60736f5. Consider uploading reports for the commit 60736f5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
+ Coverage    95.92%   96.01%   +0.08%     
===========================================
  Files          104      106       +2     
  Lines         2233     2308      +75     
  Branches       370      383      +13     
===========================================
+ Hits          2142     2216      +74     
- Misses          86       87       +1     
  Partials         5        5              
Impacted Files Coverage Δ
src/server/context.ts 0.00% <ø> (ø)
src/server/db/schema.ts 100.00% <ø> (ø)
src/server/queries/auth/auth.queries.ts 100.00% <ø> (ø)
src/server/trpc.ts 66.66% <75.00%> (+1.14%) ⬆️
...ules/Auth/components/RegisterForm/RegisterForm.tsx 92.85% <83.33%> (+1.19%) ⬆️
src/client/hooks/useLocale.ts 100.00% <100.00%> (ø)
...nt/modules/Auth/components/LoginForm/LoginForm.tsx 100.00% <100.00%> (ø)
...components/ResetPasswordForm/ResetPasswordForm.tsx 100.00% <100.00%> (ø)
...ient/modules/Auth/components/TotpForm/TotpForm.tsx 100.00% <100.00%> (ø)
.../Auth/containers/LoginContainer/LoginContainer.tsx 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger marked this pull request as ready for review May 8, 2023 17:18
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@meienberger meienberger merged commit f19508b into develop May 9, 2023
6 checks passed
@meienberger meienberger deleted the feat/internationalization branch May 9, 2023 06:29
@meienberger meienberger restored the feat/internationalization branch May 9, 2023 06:43
@meienberger meienberger deleted the feat/internationalization branch May 9, 2023 06:45
@meienberger meienberger restored the feat/internationalization branch May 9, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants