Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translations strings for my-apps page #396

Merged
merged 1 commit into from
May 9, 2023

Conversation

meienberger
Copy link
Collaborator

Purpose

This PR adds all the translation strings for the "My Apps" flow with app details, forms, and actions

@meienberger meienberger self-assigned this May 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (3b239e9) 96.02% compared to head (216e432) 96.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #396      +/-   ##
===========================================
+ Coverage    96.02%   96.09%   +0.06%     
===========================================
  Files          106      106              
  Lines         2317     2354      +37     
  Branches       384      391       +7     
===========================================
+ Hits          2225     2262      +37     
  Misses          87       87              
  Partials         5        5              
Impacted Files Coverage Δ
src/client/components/AppStatus/AppStatus.tsx 100.00% <100.00%> (ø)
src/client/components/AppTile/AppTile.tsx 100.00% <100.00%> (ø)
.../modules/Apps/components/AppActions/AppActions.tsx 94.23% <100.00%> (+0.23%) ⬆️
...odules/Apps/components/InstallForm/InstallForm.tsx 100.00% <100.00%> (ø)
...ules/Apps/components/InstallModal/InstallModal.tsx 100.00% <100.00%> (ø)
src/client/modules/Apps/components/StopModal.tsx 100.00% <100.00%> (ø)
.../client/modules/Apps/components/UninstallModal.tsx 100.00% <100.00%> (ø)
...odules/Apps/components/UpdateModal/UpdateModal.tsx 100.00% <100.00%> (ø)
...nt/modules/Apps/components/UpdateSettingsModal.tsx 100.00% <100.00%> (ø)
...ainers/AppDetailsContainer/AppDetailsContainer.tsx 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger merged commit 91e48f8 into develop May 9, 2023
8 checks passed
@meienberger meienberger deleted the feat/translate-my-apps branch May 9, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants