Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: localise app-store and settings #403

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

meienberger
Copy link
Collaborator

@meienberger meienberger commented May 15, 2023

Purpose

Localise the latest parts of the app (Settings and App Store)

@meienberger meienberger self-assigned this May 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meienberger meienberger changed the title Feat/translate app feat: localise app-store and settings May 15, 2023
@meienberger meienberger marked this pull request as ready for review May 15, 2023 06:17
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 92.20% and project coverage change: -0.05 ⚠️

Comparison is base (e006cc3) 96.09% compared to head (2426649) 96.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #403      +/-   ##
===========================================
- Coverage    96.09%   96.04%   -0.05%     
===========================================
  Files          106      106              
  Lines         2354     2378      +24     
  Branches       382      382              
===========================================
+ Hits          2262     2284      +22     
- Misses          87       89       +2     
  Partials         5        5              
Impacted Files Coverage Δ
src/client/core/constants.ts 100.00% <ø> (ø)
src/client/state/uiStore.ts 76.47% <0.00%> (-10.20%) ⬇️
src/client/utils/page-helpers.ts 100.00% <ø> (ø)
...dules/AppStore/pages/AppStorePage/AppStorePage.tsx 95.45% <66.66%> (+0.45%) ⬆️
src/server/services/system/system.service.ts 96.61% <75.00%> (+0.05%) ⬆️
.../client/modules/Apps/components/AppDetailsTabs.tsx 91.66% <85.71%> (+1.66%) ⬆️
.../AppStore/components/AppStoreTile/AppStoreTile.tsx 100.00% <100.00%> (ø)
...e/components/CategorySelector/CategorySelector.tsx 100.00% <100.00%> (ø)
...mponents/ChangePasswordForm/ChangePasswordForm.tsx 100.00% <100.00%> (ø)
...nt/modules/Settings/components/OtpForm/OtpForm.tsx 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meienberger meienberger merged commit 600ea47 into develop May 15, 2023
6 of 8 checks passed
@meienberger meienberger deleted the feat/translate-app branch May 15, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant