Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPコン福岡前日MeetUpで出た改善点 #1

Open
meihei3 opened this issue Jun 23, 2023 · 4 comments
Open

PHPコン福岡前日MeetUpで出た改善点 #1

meihei3 opened this issue Jun 23, 2023 · 4 comments

Comments

@meihei3
Copy link
Owner

meihei3 commented Jun 23, 2023 •
edited

マサカリWelcome
@meihei3
Copy link
Owner Author

meihei3 commented Jun 23, 2023

Requestのパスパラメータは withAttribute で渡す

@meihei3
Copy link
Owner Author

meihei3 commented Jun 23, 2023

Sessionインスタンス化必要？

@meihei3
Copy link
Owner Author

meihei3 commented Jun 23, 2023

ログイン中のユーザー情報を取ってくるのは１回にしたい

@zonuexe
Copy link

zonuexe commented Jun 23, 2023

resolve が RequestHandlerInterface ではなく [$handler, $params] を返すようにするか、 resolve(string $method, string $path, &$params) のようにリファレンスで返す。

https://github.com/meihei3/kenshu-backend-startdash/blob/4994fb31ab5bc6e02b591b44a49955f89f4838c4/app/Route.php#L18C2-L26

@meihei3 meihei3 changed the title PHPコン福岡前日Meet PHPコン福岡前日MeetUpマサカリ集 Jun 23, 2023
@meihei3 meihei3 changed the title PHPコン福岡前日MeetUpマサカリ集 PHPコン福岡前日MeetUpで出た改善点 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zonuexe @meihei3