Fix calculation of average value in statistics

[mccartney]

I fail to understand what does phi (Φ) is supposed to mean in the Statistics page.

[meikpiep]

It means 'average value'. In German, this is a usual sign for this. Is it unsuitable in English?

[mccartney]

Well, this was my first thought. But how come average is 4 if min is 24?

[mccartney]

Also re English - I don't think the symbol is used that widely for average, at least in non technical contexts. But I am not a native speaker.

In such contexts I saw three letters "avg" being used.

[meikpiep]

"avg" should be fine.

Nevertheless, I didn't even read the values of the screenshot, sorry for that. Will investigate the numbers.

[mccartney]

Will investigate the numbers

Could it be that the actual logic of calculations is fine on paper, but it's based on incomplete data?

A random thought looking at:

gauguin/gauguin-app/src/main/kotlin/org/piepmeyer/gauguin/ui/statistics/StatisticsActivity.kt

Line 146 in 02245da

val durationAverage = overall.solvedDurationSum / overall.gamesSolved

• maybe the solvedDurationSum has data starting the moment the statistics were introduced (recently)
• and overall.gamesSolved has a longer history?

[mccartney]

Maybe use solvedDuration.size() instead of overall.gamesSolved as the denominator?

[meikpiep]

Sorry for the delay, I'm kind of busy to calculate game difficulties on Azure, using a limited offer from Microsoft.

solvedDuration and other lists get cut to have a maximum of 50 values, so we can't use them as a source for all games played. Maybe, the data have to be restructured to enable proper calculations like this. That would lead to every installation being forced to reset their statistics...

[meikpiep]

Feel free to add your ideas!

[meikpiep]

FYI: The label got corrected.