Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets should not be in this repository #1230

Closed
Kerollmops opened this issue Feb 4, 2021 · 0 comments · Fixed by #1693
Closed

Datasets should not be in this repository #1230

Kerollmops opened this issue Feb 4, 2021 · 0 comments · Fixed by #1693
Assignees
Labels
maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@Kerollmops
Copy link
Member

We currently have our datasets files in this repository. It is not a good practice to put large non-code files in git repositories, it impacts clone and fetch times.

I propose that we move those files into a more practical file system like an S3 or anything else that will not be impacted by the number of revisions for this file. It will be easier for other teams than the core team to change the datasets without waiting for a PR to be merged on our side. Demos could use this storage, too, providing a centralized file system for all datasets provided by Meili.

@curquiza curquiza self-assigned this Jul 1, 2021
@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Aug 10, 2021
@bors bors bot closed this as completed in 2b28bc9 Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants