Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should highlight only the query word in the document #1441

Closed
curquiza opened this issue Jun 30, 2021 · 2 comments
Closed

Should highlight only the query word in the document #1441

curquiza opened this issue Jun 30, 2021 · 2 comments
Labels
bug Something isn't working as expected
Projects
Fixed issues with v0.21.0
Milestone
v0.21.0

Comments

@curquiza
Copy link
Member

Bug introduced by #1438

Steps

  • Add this document:
[
    {
        "id": 1,
        "content":"Saupoudrer le zeste d’itinéraire sur une forêt difficilement praticable pour l’attendrir et agrémenter le tout d’une neige béton et ravinée."
    }
]
  • Do this query:
{ 
    "q": "attendr",
    "attributesToHighlight": ["*"]
}

-> only attendr should be highlighted an not attendrir

⚠️ Add tests
@curquiza curquiza added this to the v0.21.0 milestone Jun 30, 2021
@curquiza curquiza added the bug Something isn't working as expected label Jun 30, 2021
@curquiza curquiza mentioned this issue Jun 30, 2021
Closed
@curquiza curquiza added this to from Transplant in Fixed issues with v0.21.0 Jun 30, 2021
@curquiza curquiza changed the title Should highlight only the part of the query Should highlight only the query word in the document Jun 30, 2021
@curquiza curquiza linked a pull request Jul 1, 2021 that will close this issue
Hotfix highlight on emojis panic #1457
Merged
@curquiza curquiza removed a link to a pull request Jul 1, 2021
Hotfix highlight on emojis panic #1457
Merged
@ManyTheFish ManyTheFish mentioned this issue Jul 1, 2021
Merged
bors bot added a commit to meilisearch/milli that referenced this issue Jul 1, 2021
@bors @ManyTheFish
Merge #280
d7bc6a6 
280: Fix matching lenghth in matching_words r=Kerollmops a=ManyTheFish

related to meilisearch/meilisearch#1441

Co-authored-by: many <maxime@meilisearch.com>
@qdequele
Copy link
Member

Fixed with meilisearch/milli#280

@curquiza
Copy link
Member Author

Closed by #1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected
Projects
No open projects
Fixed issues with v0.21.0
from Transplant
Milestone
v0.21.0
Development

No branches or pull requests
2 participants
@qdequele @curquiza