Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Setting enum fro milli in the Settings #1620

Closed
Kerollmops opened this issue Aug 24, 2021 · 2 comments · Fixed by #1623
Closed

Use the Setting enum fro milli in the Settings #1620

Kerollmops opened this issue Aug 24, 2021 · 2 comments · Fixed by #1623
Labels
enhancement New feature or improvement good first issue Good for newcomers
Milestone
v0.22.0

Comments

@Kerollmops
Copy link
Member

I would like to use the Setting enum introduced by @shekhirin in milli in MeiliSearch meilisearch/milli#148.

It makes the code must easier to read, and it would make this part of the code better.
@Kerollmops Kerollmops added enhancement New feature or improvement good first issue Good for newcomers labels Aug 24, 2021
@shekhirin
Copy link
Contributor

Hi @Kerollmops! Long time no see 😄. I think I can work on this one, should be easy to do.

@shekhirin shekhirin mentioned this issue Aug 24, 2021
Merged
@curquiza curquiza added this to the v0.22.0 milestone Aug 24, 2021
@Kerollmops
Copy link
Member Author

Kerollmops commented Aug 25, 2021 •
edited
Loading

Hey @shekhirin,

Very happy to see you ❤️ Indeed long time no see 🙈
You work so fast your 3 pull requests have hidden this notification on my Github notification feed!

@bors bors bot closed this as completed in 2d8dd87 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement good first issue Good for newcomers
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging a pull request may close this issue.

Use Setting enum shekhirin/MeiliSearch
3 participants
@Kerollmops @shekhirin @curquiza