Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download MeiliSearch binary with cURL on a M1 Apple #1661

Closed
ferdi05 opened this issue Sep 1, 2021 · 1 comment · Fixed by #1697
Closed

Download MeiliSearch binary with cURL on a M1 Apple #1661

ferdi05 opened this issue Sep 1, 2021 · 1 comment · Fixed by #1697
Labels
good first issue Good for newcomers tooling Not directly project related, like Docker, Homebrew...
Milestone
v0.23.0

Comments

@ferdi05
Copy link
Contributor

ferdi05 commented Sep 1, 2021 •
edited
Loading

Describe the bug
When trying to install MeiliSearch with cURL, it failed with the following ERROR:
ERROR: MeiliSearch binary is not available for your OS distribution or your architecture yet.
Yet when I used homebrew everything worked well.

To Reproduce

curl -L https://install.meilisearch.com | sh
./meilisearch

with an Apple M1 computer

Screenshots
Capture d’écran 2021-09-01 à 14 52 20
@curquiza curquiza added the bug Something isn't working as expected label Sep 1, 2021
@curquiza
Copy link
Member

curquiza commented Sep 1, 2021 •
edited
Loading

Thanks for the report!

We should make the script work for Mac M1 since the binary does work for this OS and this architecture.
I put it as a good first issue 🙂

@curquiza curquiza added good first issue Good for newcomers tooling Not directly project related, like Docker, Homebrew... and removed bug Something isn't working as expected labels Sep 1, 2021
@curquiza curquiza changed the title Unable to download a MeiliSearch binary with cURL on a M1 Apple Download MeiliSearch binary with cURL on a M1 Apple Sep 1, 2021
@k-nasa k-nasa mentioned this issue Sep 11, 2021
Merged
@curquiza curquiza added this to the v0.23.0 milestone Sep 14, 2021
@curquiza curquiza modified the milestones: v0.23.0, v0.24.0 Sep 28, 2021
bors bot added a commit that referenced this issue Sep 30, 2021
@bors @k-nasa
Merge #1697
06aa015 
1697: Make exec binary for M1 mac available for download r=MarinPostma a=k-nasa

## Why

fix: #1661

Now, Do not supported getting exec file for m1 mac on using`download-latest.sh`.


## What

Download x86 binary when run `download-latest.sh` on m1 mac, because it can execute binary targeting x86.

## Proof

I verified like this.
I got executable binary on M1 mac 💡 

```sh
:) % arch
arm64

:) % ./download-latest.sh
Downloading MeiliSearch binary v0.21.1 for macos, architecture amd64...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   631  100   631    0     0   2035      0 --:--:-- --:--:-- --:--:--  2035
100 43.5M  100 43.5M    0     0  7826k      0  0:00:05  0:00:05 --:--:-- 9123k
MeiliSearch binary successfully downloaded as 'meilisearch' file.

Run it:
    $ ./meilisearch
Usage:
    $ ./meilisearch --help

:) % file ./meilisearch
./meilisearch: Mach-O 64-bit executable x86_64

:) % ./meilisearch --help # this is execuable
meilisearch-http 0.21.1
...
...
```

Co-authored-by: k-nasa <htilcs1115@gmail.com>
Co-authored-by: nasa <htilcs1115@gmail.com>
@bors bors bot closed this as completed in 44a2ff0 Sep 30, 2021
@curquiza curquiza modified the milestones: v0.24.0, v0.23.0 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tooling Not directly project related, like Docker, Homebrew...
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging a pull request may close this issue.

Make exec binary for M1 mac available for download k-nasa/MeiliSearch
2 participants
@ferdi05 @curquiza