Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search is long for some queries #1707

Closed
curquiza opened this issue Sep 20, 2021 · 1 comment
Closed

Search is long for some queries #1707

curquiza opened this issue Sep 20, 2021 · 1 comment
Labels
bug Something isn't working as expected performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption
Projects
Bug triage
Milestone
v0.23.0

Comments

@curquiza
Copy link
Member

We noticed some slow times during the search with the small dataset movies.json containing 31944 documents.

The following searches are slow:

  • hel -> around 250ms
  • ame -> around 150ms

A "classic" search with this dataset is usually below 10ms (check with a or amer)

We need to investigate why we have this problem with some queries. Ant helps/inputs are welcome :)
@curquiza curquiza added bug Something isn't working as expected performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption labels Sep 20, 2021
@curquiza curquiza added this to Candidates in Bug triage via automation Sep 20, 2021
@curquiza curquiza removed this from Candidates in Bug triage Sep 20, 2021
@curquiza curquiza added this to Candidates in Bug triage via automation Sep 20, 2021
@curquiza curquiza moved this from Candidates to Bugs - severity 3 in Bug triage Sep 20, 2021
@ManyTheFish ManyTheFish mentioned this issue Sep 29, 2021
Merged
@curquiza curquiza added this to the v0.23.0 milestone Sep 29, 2021
bors bot added a commit to meilisearch/milli that referenced this issue Sep 29, 2021
@bors @ManyTheFish
Merge #378
6a057a3 
378: Hotfix meilisearch#1707 r=Kerollmops a=ManyTheFish

This PR contains an ugly quick fix of [meilisearch#1707](meilisearch/meilisearch#1707).

- remove comparison reverse on rank. Enhancing relevancy and performances
- iterate over level 0 only. Enhancing performances.

A better fix is in development.

Co-authored-by: many <maxime@meilisearch.com>
Co-authored-by: Many <legendre.maxime.isn@gmail.com>
@curquiza
Copy link
Member Author

Closed by #1711 containing milli v0.17.0

Bug triage automation moved this from Bugs - severity 3 to Done Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption
Projects
No open projects
Bug triage
Done
Milestone
v0.23.0
Development

No branches or pull requests
1 participant
@curquiza