Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: have one file for docker image CI instead of two #1901

Closed
curquiza opened this issue Nov 15, 2021 · 0 comments · Fixed by #2477 or #2491
Closed

Refactoring: have one file for docker image CI instead of two #1901

curquiza opened this issue Nov 15, 2021 · 0 comments · Fixed by #2477 or #2491
Labels
contribution accepted This issue accepts external contributions good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v0.28.0 PRs/issues solved in v0.28.0
Milestone
v0.28.0

Comments

@curquiza
Copy link
Member

⚠️ Should be done once #1897 is merged

We should find a way to have only one file related to the docker image CI instead of two, for maintenance reasons.

Here are the current files:

-> The CI logic should be handled in one file only.
@curquiza curquiza added good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) labels Nov 15, 2021
@curquiza curquiza mentioned this issue Nov 15, 2021
Merged
4 tasks
bors bot added a commit that referenced this issue Nov 15, 2021
@bors @curquiza
Merge #1897
53fc2ed 
1897: Add ARM image for Docker to CI r=irevoire a=curquiza

Fixes #1315 

- [x] Publish MeiliSearch's docker image for `arm64`
- [x] Add `workflow_dispatch` event in case we need to re-trigger it after a failure without creating a new release
- [x] Use our own server to run the github runner since this CI is really slow (1h instead of 4h)
- [x] Open an issue for a refactor by merging both files in one file (#1901)

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@curquiza curquiza added the contribution accepted This issue accepts external contributions label Dec 8, 2021
choznerol added a commit to choznerol/meilisearch that referenced this issue Jun 7, 2022
@choznerol
ci(.github): merge publish-docker-*.yml
cf7eeeb 
close meilisearch#1901
choznerol added a commit to choznerol/meilisearch that referenced this issue Jun 7, 2022
@choznerol
Merge publish-docker-latest.yml & publish-docker-tag.yml
5448b66 
close meilisearch#1901
@choznerol choznerol mentioned this issue Jun 7, 2022
Merged
3 tasks
choznerol added a commit to choznerol/meilisearch that referenced this issue Jun 7, 2022
@choznerol
Merge publish-docker-latest.yml & publish-docker-tag.yml
fcbcd8d 
close meilisearch#1901
@curquiza curquiza mentioned this issue Jun 8, 2022
Merged
2 tasks
bors bot added a commit that referenced this issue Jun 9, 2022
@bors @choznerol @curquiza
Merge #2491
680606f 
2491: Improve Docker CIs r=curquiza a=curquiza

Close #1901 

Continuing work of 

- [x] Merge two docker CI in one (#2477). The latest tag is still only push for the official release.
- [x] Add cron job in GHA to run the CI (without publishing the image) every day. This will check the docker build is working.

Co-authored-by: Lawrence Chou <lawrencechou1024@gmail.com>
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@curquiza curquiza added this to the v0.28.0 milestone Jun 9, 2022
@bors bors bot closed this as completed in afcc493 Jun 9, 2022
@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution accepted This issue accepts external contributions good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
1 participant
@curquiza