Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.25.0rc2 keys returned by GET /keys should be nested in a results field #2052

Closed
bidoubiwa opened this issue Jan 4, 2022 · 2 comments · Fixed by #2054
Closed

V0.25.0rc2 keys returned by GET /keys should be nested in a results field #2052

bidoubiwa opened this issue Jan 4, 2022 · 2 comments · Fixed by #2054
Assignees
@ManyTheFish
Labels
bug Something isn't working as expected v0.25.0 PRs/issues solved in v0.25.0
Milestone
v0.25.0

Comments

@bidoubiwa
Copy link
Contributor

Describe the bug
Return of the GET /keys route is for the moment returned as an array containing the keys.
Per the specifications it is described as being inside a results field

To Reproduce
Steps to reproduce the behavior:

  1. make a requesting on GET /keys
  2. Array with keys is returned

Expected behavior
Should be in a results field

MeiliSearch version: [e.g. v0.20.0]
v0.25.0rc2
@curquiza
Copy link
Member

curquiza commented Jan 4, 2022

Thanks @bidoubiwa for this! And sorry we missed it, I assigned @ManyTheFish on it :)

@curquiza curquiza added the bug Something isn't working as expected label Jan 4, 2022
@curquiza curquiza added this to the v0.25.0 milestone Jan 4, 2022
@ManyTheFish ManyTheFish mentioned this issue Jan 4, 2022
Merged
@curquiza curquiza linked a pull request Jan 4, 2022 that will close this issue
Bug(auth): Wrap key list in results #2054
Merged
bors bot added a commit that referenced this issue Jan 4, 2022
@bors @ManyTheFish
Merge #2054
d53c61a 
2054: Bug(auth): Wrap key list in results r=irevoire a=ManyTheFish

fix #2052

Co-authored-by: ManyTheFish <many@meilisearch.com>
@curquiza
Copy link
Member

curquiza commented Jan 4, 2022

Fixed by #2054

@curquiza curquiza closed this as completed Jan 4, 2022
@curquiza curquiza mentioned this issue Jan 4, 2022
Merged
@curquiza curquiza added the v0.25.0 PRs/issues solved in v0.25.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManyTheFish ManyTheFish

Labels
bug Something isn't working as expected v0.25.0 PRs/issues solved in v0.25.0
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging a pull request may close this issue.

Bug(auth): Wrap key list in results meilisearch/meilisearch
3 participants
@ManyTheFish @curquiza @bidoubiwa