Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

& Breaks Search on Dashboard #986

Closed
jcohlmeyer opened this issue Oct 3, 2020 · 1 comment · Fixed by #989
Closed

& Breaks Search on Dashboard #986

jcohlmeyer opened this issue Oct 3, 2020 · 1 comment · Fixed by #989
Labels
bug Something isn't working as expected good first issue Good for newcomers
Milestone

Comments

@jcohlmeyer
Copy link

jcohlmeyer commented Oct 3, 2020

Describe the bug
When entering a search in the provided MeiliSearch dashboard the search is broken, returning a 400 error as the & breaks the search request URL. This is because the search string is not URL encoded using encodeURIComponent(search.value).

To Reproduce
Steps to reproduce the behaviour:

  1. Go to the MeiliSearch dashboard: http://localhost:7700
  2. Enter a search with an ampersand (&) in it.
  3. See the search does not complete and a 400 error is returned in the network tab

Expected behaviour
A search with an ampersand should work and the & should be URL encoded.

Desktop (please complete the following information):

  • OS: macOS 10.15.7 (19H2)
  • Browser Firefox
  • Version 82.0b4 (64-bit)
@ManyTheFish ManyTheFish added breaking bug Something isn't working as expected labels Oct 5, 2020
@ManyTheFish ManyTheFish added this to the 11/20 milestone Oct 5, 2020
@qdequele
Copy link
Member

qdequele commented Oct 5, 2020

Thanks @jcohlmeyer, as it is a simple issue, why not letting the hacktoberfest participants fix it? 😉

bors bot added a commit that referenced this issue Oct 6, 2020
989: URL encode search in web UI r=LegendreM a=akrantz01

Fixes #986 

Co-authored-by: Alex Krantz <alex@krantz.dev>
@bors bors bot closed this as completed in 726e867 Oct 6, 2020
@bors bors bot closed this as completed in #989 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants