fix running URL display #1206
Merged
fix running URL display #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by doing that you can just click on it in the terminal if you want
|
@MarinPostma I cannot compile MeiliSearch on my computer, so I wasn't able to test, but I assume it will work since I just updated a string... Also, let me know if I needed to tag someone else. |
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
+ Coverage 77.52% 79.95% +2.43%
==========================================
Files 105 105
Lines 12277 12154 -123
==========================================
+ Hits 9518 9718 +200
+ Misses 2759 2436 -323
Continue to review full report at Codecov.
|
|
Uhm would that work with tls? |
|
You may have a warning as I changed only the display of the running URL. |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Mar 26, 2021
1310: Fix display of http address r=MarinPostma a=curquiza Wrong display introduced by #1206 Now displaying: <img width="968" alt="Capture d’écran 2021-03-26 à 12 04 59" src="https://user-images.githubusercontent.com/20380692/112622594-8c173080-8e2b-11eb-81c3-5876d273e5fa.png"> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Mar 29, 2021
1310: Fix display of http address r=MarinPostma a=curquiza Wrong display introduced by #1206 Now displaying: <img width="968" alt="Capture d’écran 2021-03-26 à 12 04 59" src="https://user-images.githubusercontent.com/20380692/112622594-8c173080-8e2b-11eb-81c3-5876d273e5fa.png"> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by doing that you can just click on it in the terminal if you want