Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending items no longer works #67

Open
Kerollmops opened this issue Mar 9, 2024 · 0 comments
Open

Appending items no longer works #67

Kerollmops opened this issue Mar 9, 2024 · 0 comments
Labels
bug Something isn't working performance
Milestone

Comments

@Kerollmops
Copy link
Member

Kerollmops commented Mar 9, 2024

It is no longer possible to append items in the database because we are updating the updated item IDs that live after the item entries. We could move the metadata information before the item entries. We must add a test for this method.

arroy/src/writer.rs

Lines 166 to 176 in 19e0a07

let mut updated = self
.database
.remap_data_type::<RoaringBitmapCodec>()
.get(wtxn, &Key::updated(self.index))?
.unwrap_or_default();
updated.insert(item);
self.database.remap_data_type::<RoaringBitmapCodec>().put(
wtxn,
&Key::updated(self.index),
&updated,
)?;

@Kerollmops Kerollmops added bug Something isn't working performance labels Mar 9, 2024
@Kerollmops Kerollmops added this to the v0.2.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

No branches or pull requests

1 participant