Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nb_hits update in config file #17

Closed
curquiza opened this issue May 13, 2020 · 4 comments · Fixed by #48
Closed

Remove nb_hits update in config file #17

curquiza opened this issue May 13, 2020 · 4 comments · Fixed by #48

Comments

@curquiza
Copy link
Member

Since we don't use this metric (we indeed don't update the config file and push it to GitHub after updating it) we should remove the file update in the code.

But I think it's still interesting to keep the final prompt that says:

Nb hits: XXX
@curquiza curquiza changed the title Remove nb_hits part in config file Remove nb_hits update in config file May 13, 2020
@curquiza curquiza added this to Open issues in SDKs & Integrations via automation May 13, 2020
@renehernandez
Copy link
Contributor

@curquiza I am going to take a look at this next

@renehernandez
Copy link
Contributor

renehernandez commented Jul 8, 2020

I took a look at the codebase and we can solve it by removing this line: https://github.com/meilisearch/docs-scraper/blob/master/scraper/src/index.py#L106

Optionally, we could remove all the code related with updating the number of hits:

@curquiza
Copy link
Member Author

curquiza commented Jul 8, 2020

It looks ok for me 🙂
Keep in mind we still want the prompt in the terminal indicating the number of hits at the end. Maybe it would imply to extract some code of these parts.

@renehernandez
Copy link
Contributor

It looks ok for me 🙂
Keep in mind we still want the prompt in the terminal indicating the number of hits at the end. Maybe it would imply to extract some code of these parts.

The number of hits is obtained from the DocumentationSpider.NB_INDEXED field. I'll double check anyways

SDKs & Integrations automation moved this from Open issues to Done Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants