Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Criteria names changed with the engine rewritte #91

Closed
Kerollmops opened this issue Dec 12, 2019 · 3 comments
Closed

Criteria names changed with the engine rewritte #91

Kerollmops opened this issue Dec 12, 2019 · 3 comments

Comments

@Kerollmops
Copy link
Member

Kerollmops commented Dec 12, 2019 •
edited

When I rewrote the core engine algorithm (i.e. v0.8.5-alpha.1 & v0.8.5-beta.1) to improve performances, I take the time to rename the criteria with shorter and clear names.

  • sum of typos becomes typo
  • number of words becomes words
  • words proximity becomes proximity
  • sum of words attribute becomes attribute
  • sum of words position becomes words position
  • exact remains exact

This is just a remainder to update the documentation examples that refers to old names.
@tpayet tpayet added this to the v0.8.5 milestone Dec 12, 2019
@bidoubiwa
Copy link
Contributor

Is this change in version v0.8 or will be added in v0.9 ?

@bidoubiwa bidoubiwa modified the milestones: v0.8.5, v0.9.0 Jan 7, 2020
@bidoubiwa
Copy link
Contributor

fixes: #103

@Kerollmops
Copy link
Member Author

Kerollmops commented Mar 18, 2020 •
edited

Just to be sure, the exact criterion is also renamed exactness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kerollmops @tpayet @bidoubiwa