Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetKeys method #122

Closed
curquiza opened this issue May 25, 2021 · 3 comments
Closed

Implement GetKeys method #122

curquiza opened this issue May 25, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Create GetKeys according to this route: https://docs.meilisearch.com/reference/api/keys.html#get-keys

@curquiza curquiza added the good first issue Good for newcomers label May 25, 2021
@gethari
Copy link
Contributor

gethari commented Jun 7, 2021

@curquiza I thought of picking this up and I have some suggestions to improve the SDK. Currently, the file alignment is spread in the root, all the Models , Extensions and Client everything is kept outside. Would it be ok, if we create a structured approach either follow stack driven design or domain driven?

Eg : We can have all response folders under Models. In the future, as the Meilisearch grows if there will be a lot more APIs (assuming ) it will be quite hefty seeing all files outside. I can raise a PR along with this route implementation if that's ok with you 😃

@curquiza
Copy link
Member Author

curquiza commented Jun 7, 2021

Thanks for your suggestion @gethari!

FYI, MeiliSearch will not add so many routes 🙂 I agree with improving the current structure of this SDK but it should not be too complex regarding the goal of the SDK.
I really would like to concretely see what you mean with a PR, if you have time of course, because I cannot guarantee we will merge it. But if it helps us for the maintenance it would be awesome!!
Another really important rule when refactoring: the usage of the SDK, I mean the README and the usage of methods, must stay unchanged 🙂

@curquiza
Copy link
Member Author

Closed in favor of this PR #217. WIll be released in meilisearch-dotnet v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants