Add tasks filters for v0.30 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
0ca962c
to
455cced
Compare
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
455cced
to
9a66fbd
Compare
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
4 times, most recently
from
f2c7017
to
11f2deb
Compare
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
11f2deb
to
3cefbd6
Compare
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
3cefbd6
to
029e503
Compare
brunoocasali
reviewed
Dec 6, 2022
| @@ -390,9 +377,7 @@ func convertKeyToParsedKey(key Key) (resp KeyParsed) { | |||
| // Convert time.Time to *string to feat the exact ISO-8601 | |||
| // format of Meilisearch | |||
| if !key.ExpiresAt.IsZero() { | |||
| const Format = "2006-01-02T15:04:05" | |||
There was a problem hiding this comment.
This was really the way go uses to format dates? 😅
There was a problem hiding this comment.
I don't know any other way except Format method
There was a problem hiding this comment.
I mean, in other languages is very common to have YYYY-MM-DD or something like this, but in this case you're using a real date value to do the format...
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
02ee64d
to
c52166a
Compare
alallema
force-pushed
the
add_tasks_filters_for_v0.30
branch
from
c52166a
to
0d57189
Compare
bors bot
added a commit
that referenced
this pull request
Dec 14, 2022
382: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Done: - #390 - #392 - #395 - #396 - #397 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Dec 15, 2022
398: Update version for the next release (0.22.0) r=alallema a=alallema This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - New `pagination` strategy with the search parameters `Page` and `HitsPerPage` #392 - New filters on `GetTasks`: `UID`, `BeforeEnqueuedAt`, `AfterEnqueuedAt`, ... see #390 - New `client.CancelTasks` method that lets you cancel `enqueued` and `processing` tasks #395 - New `client.DeleteTasks` method that lets you delete tasks #396 - New `client.SwapIndexes` method that lets you swap two indexes #397 - New fields on `Task.Details` #395 ##⚠️ Breaking change - Parameters on `GetTasks` name changes: #390 - `Status` -> `Statuses` - `IndexUID` -> `IndexUIDS` - `Type` -> `Types` Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new filters on the
get /tasksroute.Present in this spec
V0.30.0
in TasksQuery:
uidCanceledByBeforeEnqueuedAtAfterEnqueuedAtBeforeStartedAtAfterStatedAtBeforeFinishedAtAfterFinishedAtTests:
uidcanceledBybeforeEnqueuedAt