Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Meilisearch export #1600

Closed
Strift opened this issue Nov 13, 2023 · 1 comment · Fixed by #1601
Closed

Add Meilisearch export #1600

Strift opened this issue Nov 13, 2023 · 1 comment · Fixed by #1601
Labels
good first issue Good for newcomers

Comments

@Strift
Copy link

Strift commented Nov 13, 2023

Hello Meilisearch JS maintainers 👋

Description
For a while now the official spelling of Meilisearch is Meilisearch (with a lowercase s). The export of this package is MeiliSearch which is always weird to read. 😬

Proposal
My proposal is to export the MeiliSearch class with the identifier Meilisearch too.
I would not remove the MeiliSearch export for now as I think this is clearly not worth creating a breaking change.
@Strift Strift added the good first issue Good for newcomers label Nov 13, 2023
@Dhoni77
Copy link
Contributor

Dhoni77 commented Nov 13, 2023

Hi @Strift I would like to work on this

@Dhoni77 Dhoni77 mentioned this issue Nov 13, 2023
Merged
3 tasks
@meili-bors meili-bors bot closed this as completed in 3710a89 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add export for MeiliSearch as Meilisearch Dhoni77/meilisearch-js
2 participants
@Strift @Dhoni77