New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update `Embedder` type #1637

Closed

mdubus opened this issue Mar 12, 2024 · 0 comments

Labels

enhancement good first issue

Member

mdubus commented Mar 12, 2024 •

edited

Loading

Description
The Embedder type is currently defined like this:

export type Embedder =
  | OpenAiEmbedder
  | HuggingFaceEmbedder
  | UserProvidedEmbedder

I should accept null too since this is a valid value (we can update the embedders and set one to null when we want to delete it)

Expected behavior
Accept null as a valid value

The text was updated successfully, but these errors were encountered:

mdubus added the enhancement label

curquiza added the good first issue label

amit-ksh mentioned this issue

Add null to Embedder type #1646

Merged

3 tasks

Strift closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment