You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose we remove this polyfill, users of this library can import a polyfill script for fetch (browser) (node) and the other stuff themselves in the few cases where they might still need to do so, and if they're targeting IE11, they already need to do this with URLhttps://github.com/lifaon74/url-polyfill. I believe polyfilling should be the responsibility of the final apps/websites.
#1656 is kind of a blocker for this, as removing cross-fetch would break tests, and that PR already fixes them.
The text was updated successfully, but these errors were encountered:
As detailed in #1610,
cross-fetch
isn't helping much. The only thing it does is usenode-fetch
on older Node.js versions.Also we are using two additional web standards that won't run on IE11 and we're not polyfilling:
meilisearch-js/src/http-requests.ts
Lines 129 to 138 in cd61a8c
I propose we remove this polyfill, users of this library can import a polyfill script for
fetch
(browser) (node) and the other stuff themselves in the few cases where they might still need to do so, and if they're targeting IE11, they already need to do this withURL
https://github.com/lifaon74/url-polyfill. I believe polyfilling should be the responsibility of the final apps/websites.#1656 is kind of a blocker for this, as removing
cross-fetch
would break tests, and that PR already fixes them.The text was updated successfully, but these errors were encountered: