Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider matching the SDK version to the server version #199

Closed
georgeboot opened this issue Aug 26, 2021 · 4 comments
Closed

Consider matching the SDK version to the server version #199

georgeboot opened this issue Aug 26, 2021 · 4 comments

Comments

@georgeboot
Copy link

Perhaps this package should match the server version.

The update to 0.21.0 had some breaking changes on the server side. However, this package can technically still be used with an older server, though that will result in error.

I submitted a PR to Laravel Scout a couple of days ago to add support for these changes. Scout depends on this package, but there is currently no way to check what api version should be used, other than calling the server itself (which is not performant).

It would in my opinion be better if this package would match the server version. That way, Scout (and other packages) could simply check what version of the SDK is installed, and assume that the server will be of a compatible version. It will be op to the user to make sure the versions of the SDK and server match, but there is no way around that.

@georgeboot georgeboot changed the title Consider matching the Meilisearch server version Consider matching the SDK version to the server version Aug 26, 2021
@curquiza
Copy link
Member

curquiza commented Aug 26, 2021

Hello @georgeboot!

This is something we already tried in the past, but we quickly changed our mind: indeed, the breaking changes of our SDKs are not always related to the breaking changes of MeiliSearch, and the contrary.
So, we don't want to reproduce. When MeiliSearch will be stable (with a version v1.X.Y) and our SDKs as well, we will reconsider it.

We understand this is not really convenient at the moment, sorry for that, but since we are not stable, this is not something we want to do :)
Thanks for your suggestion anyway

@georgeboot
Copy link
Author

Nah 100%, I get what you're saying.

What would you recommend for packaged like Scout though? How should they know what parameters to use? Hardcore the SDK version and release a major update for new versions of the SDK?

@curquiza
Copy link
Member

curquiza commented Aug 26, 2021

Since MeiliSearch is not stable I recommend being compatible only with the latest version of MeiliSearch, and the latest version of the package.
When the meilisearch-php is updated (with major changes for scout), I create a PR for the scoot package like this one so that the laravel scout package is always up-to-date.

@georgeboot
Copy link
Author

Understood; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants