-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider matching the SDK version to the server version #199
Comments
Hello @georgeboot! This is something we already tried in the past, but we quickly changed our mind: indeed, the breaking changes of our SDKs are not always related to the breaking changes of MeiliSearch, and the contrary. We understand this is not really convenient at the moment, sorry for that, but since we are not stable, this is not something we want to do :) |
Nah 100%, I get what you're saying. What would you recommend for packaged like Scout though? How should they know what parameters to use? Hardcore the SDK version and release a major update for new versions of the SDK? |
Since MeiliSearch is not stable I recommend being compatible only with the latest version of MeiliSearch, and the latest version of the package. |
Understood; thanks! |
Perhaps this package should match the server version.
The update to 0.21.0 had some breaking changes on the server side. However, this package can technically still be used with an older server, though that will result in error.
I submitted a PR to Laravel Scout a couple of days ago to add support for these changes. Scout depends on this package, but there is currently no way to check what api version should be used, other than calling the server itself (which is not performant).
It would in my opinion be better if this package would match the server version. That way, Scout (and other packages) could simply check what version of the SDK is installed, and assume that the server will be of a compatible version. It will be op to the user to make sure the versions of the SDK and server match, but there is no way around that.
The text was updated successfully, but these errors were encountered: