Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rspec 3 #93

Closed
jitingcn opened this issue Dec 21, 2021 · 0 comments · Fixed by #94
Closed

upgrade rspec 3 #93

jitingcn opened this issue Dec 21, 2021 · 0 comments · Fixed by #94

Comments

@jitingcn
Copy link
Contributor

Description
I got an error when I ran rake after bundle install, After some searching (sof), the issue is that rake 11.0 removed the last_comment method, which was used by rspec-core (< 3.4.4)

Possible solutions include restricting rake version

gem 'rake', '< 11.0'

or upgrading the rspec version, which I think is a good option for long-term consideration.

This issue only affects run rake locally and does not affect run rspec tests alone, or the normal use the gem.

Logs

$ rake
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00007f1be23e2588>
/home/jiting/RubymineProjects/meilisearch-rails/Rakefile:16:in `new'
/home/jiting/RubymineProjects/meilisearch-rails/Rakefile:16:in `<top (required)>'
/home/jiting/.rbenv/versions/2.7.2/bin/bundle:23:in `load'
/home/jiting/.rbenv/versions/2.7.2/bin/bundle:23:in `<main>'

Environment (please complete the following information):

  • OS: Arch Linux
  • MeiliSearch version: v.0.24.0
  • meilisearch-rails version: 0.3.0
  • Ruby version: 2.7.2
  • Rake version: 13.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant