Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.6] support embedders setting #541

Open
CommanderStorm opened this issue Jan 22, 2024 · 3 comments · May be fixed by #554
Open

[v1.6] support embedders setting #541

CommanderStorm opened this issue Jan 22, 2024 · 3 comments · May be fixed by #554
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CommanderStorm
Copy link

CommanderStorm commented Jan 22, 2024

Description
Currently, the embedders cannot be added via the sdk, only via http.

Basic example

instead of

curl \       
  -X PATCH 'http://localhost:7700/indexes/movies/settings' \
  -H 'Content-Type: application/json' \
  --data-binary '{
    "embedders": {
      "default": {
        "source": "huggingFace",
        "model": "bge-base-en-v1.5",
        "documentTemplate": "A movie titled '{{doc.title}}' whose description starts with {{doc.body|truncatewords: 20}}"
      }
    }
  }'
Settings::new().with_embedders(HashSet::from("default", Embedder::HuggingFace{...}))

Other
If adding such features to the sdk BEFORE they are out of the experimental stage, I could implement this.
If not, that is fine too ^^

@curquiza curquiza added the enhancement New feature or request label Jan 23, 2024
@CommanderStorm
Copy link
Author

CommanderStorm commented Feb 26, 2024

@curquiza
You added the enhancement label. Does this mean I can work on this, or do you think that experimental features should only be implemented once stable? ^^

@curquiza
Copy link
Member

Sorry, you are right, I was not clear at all.
Yes, you can work on this 😊

I'm curious, do you use this feature + rust SDK, or is it only to make an opensource contribution? 😊

@curquiza curquiza added the good first issue Good for newcomers label Feb 29, 2024
@CommanderStorm CommanderStorm linked a pull request Mar 2, 2024 that will close this issue
4 tasks
@CommanderStorm
Copy link
Author

I'm curious, do you use this feature + rust SDK

Yes, but not yet in production (in my uni, not a company).
I have toyed with it in an experimental project and thought that adding this to the sdk might be a good excuse to learn how this should be configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants