-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check mini-dashboard is up #1767
Comments
So, I think a relatively easy way to test that the mini-dashboard loads correctly is to check that all the assets are served correctly. To do so, we can take some inspiration from the method that creates the routes for the assets. We use the route path, and send a |
hii, @curquiza and @MarinPostma can I work on this issue |
@vaibhav135, sure, I'm assigning you. Don't hesitate if you need more guidance. |
@MarinPostma Thanks, I'll let you know about my progress and will ask for the further guidance that I may need. |
Hi, @MarinPostma, I've compiled the project from source locally. I've already ran it on localhost:7700. But the problem is I can't search for anything as it is not showing any result. I suppose since I am in development mode I don't necessarily need the master key or any key as a matter of fact. Thank you |
Hey @vaibhav135 , have you added any documents to your db? |
@MarinPostma there is already a sample document in datasets/movies/movies.json but how do I add it to the DB. Do I create a node.js file then use MongoDB or something like that. I am a little bit confused |
@MarinPostma Do i need to execute a curl request
something like the above example then replace the data value with the dataset path or something like that |
Yes you can pass |
@MarinPostma thanks finally, added documents to the DB that worked. |
Hello @vaibhav135 and @MarinPostma, the movie.json dataset is going to be removed, see the draft PR: #1693 You can pass the document you planned to pass at first @vaibhav135 :) And thank you for your PR! |
@MarinPostma and @curquiza :- P.S. Rust is weird more like c/c++ added with go. |
Hi @vaibhav135, it sounds like you might be over thinking this :) |
Yes, just open a draft pr and I'll take a look at it 😉 |
Hello @vaibhav135, I will remove the assignation since we did not get any PR from you, we can understand this is not an easy PR and you may not have the time to do it 🙂 In general, and from now, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the other volunteers contributors to open a PR to fix this issue. Thanks again for your involvement and feel free to still open a PR if you have the time 🙂 |
Will this policy apply to those issues that already have an assignee before you claim this new policy? |
Hi, @curquiza actually I am still looking at it. Actually, I am also learning rust so it's taking me quite some time. Sorry for not participating actively. By the way, I am also fairly new to open source so yeah. Sorry I was just overwhelmed looking at the source code. But starting to figure out things now. |
Hello @CNLHC and @vaibhav135! @CNLHC, actually here is our policy about Hacktoberfest, and about contribution in general, and we never mention the issue assignation: https://github.com/meilisearch/MeiliSearch/blob/main/CONTRIBUTING.md#hacktoberfest Sorry @vaibhav135 this made you rush! This was not the goal! We can understand you need time to learn rust, but if a PR is open to fix this issue, even if it's not yours, you are more than welcome to review it and give your feedback. This will make you learn as well :) Thanks to both of you for your involvement anyway, and sorry for the confusion. |
@curquiza thanks, I think I took the problem without even knowing it properly. Next time I'll be better with my judgment I will continue to work on this project since I really like it. I have unassigned myself. Thank u I learned a lot next time I'll discuss the whole thing before asking to get assigned. |
Thanks for understanding, and don't hesitate to ask all the questions you need :) |
MeiliSearch integrates an interface so that the users can search in a friendly user interface we call the Mini Dashboard.
When launching MeiliSearch locally, the mini dashboard is accessible at
http://localhost:7700
We need to add a test that checks the mini-dashabord is up when compiling and running MeiliSearch.
@MarinPostma will add some mentoring steps to guide you through this issue :)
The text was updated successfully, but these errors were encountered: