Create too_many_open files errors

[curquiza]

When Meilisearch opens too many FDs, you get the following error

{
    "message": "An internal error has occurred. `Too many open files`.",
    "code": "internal",
    "type": "internal",
    "link": "https://docs.meilisearch.com/errors#internal"
}

We want to replace

• the code (not type) internal by too_many_open_files
• the link #internal by #too_many_open_files

TODO

• Implement changes in Milli
• Release a Milli version containing these changes
• Bump this new Milli version in Meilisearch and merge it into main
• Update the associated specification

Impacted teams

Pinging every teams that might use this, @meilisearch/docs-team (a related issue) and @meilisearch/integration-team
Also @meilisearch/cloud-team I don't know if you would be impacted by this change

[semi-infiknight]

please assign me this issue

[curquiza]

Hello @semi-infiknight

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

FYI, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊

[Rutam21]

@curquiza @irevoire Can you help me with finding the place where this change needs to be done? Thanks.

[irevoire]

Hey @Rutam21,

I think you'll need to add a variant in the Code to represent the error.
And then in the MilliError enum you should look for every variant that can output a TooManyOpenFiles error and map it to the code you created before 👍

[curquiza]

Moving this to v1 milestones, we will not have the time to fix it for v0.30.0

[brunoocasali]

@curquiza This is not a breaking change anymore based on the decision here meilisearch/engine-team#38 right?

[curquiza]

It is still breaking because before people used the internal code to get this error, now they have to use too_many_open_files

The meilisearch/engine-team#38 PR is about warning people using strong languages that would expect a specific and exhaustive list of types (here all the code). Indeed, if we add a new one in a new context (so not breaking) they will have their code broken because this new type is not expected. They have to include an unknown type in the exhaustive list they are expected to retrieve.

[brunoocasali]

Ah, ok, so it is because it is an "update/change", not a "creation", correct?

Because the issue name gave me the sensation that something new would be introduced, but yeah, carefully reading the content + your message made me get it :)

[curquiza]

Exactly. There is a nuance. In error handler, creation can also be a modification 😊