Some settings can recieve null as a value while they shouln't

[bidoubiwa]

Describe the bug
Some settings, I only have two examples but there are probably more, can receive the value null during an update while it should raise an error.

Example: See spec

🔴 Sending a value with a different type than Boolean for the enabled field returns an bad_request error.
🔴 Sending a value with a different type than Array of String for the disableOnAttributes field returns an bad_request error.

Upon receiving null as a value, they are reset to their default value

To Reproduce
Steps to reproduce the behavior:

1. Create an index
2. Update the settings { typoTolerance: { enabled: false }}
3. Check if is indeed has false as a value
4. Update the settings { typoTolerance: { enabled: null }}
5. Check the settings, enabled is now true

Expected behavior
Should follow the spec, either the spec should change or the behavior.

Meilisearch version: v0.29.1

[curquiza]

Thanks for the report @bidoubiwa
Will try to fix this for v0.30.0 (during pre-release) or for v1 if too risky to fix this during a pre-release phase

[guimachiavelli]

We will probably want to clarify the behaviour when assigning null to settings in the docs. I took the liberty of adding the impacts-docs myself, if that's alright.

[curquiza]

discussed with @gmourier -> the spec should be followed, not modified.

[Pranav-yadav]

@curquiza I can work on this if I know which settings are affected?
maybe a list with permalinks to all of such settings would be appreciated :)

[curquiza]

Hello @Pranav-yadav

We don't know exactly which ones are concerned, this issue involves also a small investigation by testing all the settings
The list of all the settings present in Meilisearch are described in the docs here

[Pranav-yadav]

Ohh! Then, I shall come to this after tackling easier ones... hahaha

[ManyTheFish]

Are we sure about this? Considering it as a bug and fixing this issue would forbid the user to reset any settings under typoTolerance settings. This means that the only way to reset a part of the typoTolerance settings is to:

1. call DELETE /indexes/:uid/settings/typo-tolerance to reset the whole typoTolerance settings
2. set the settings that we didn't want to reset

poke @gmourier

[dureuill]

Discussed with @Kerollmops, @ManyTheFish and @gmourier:

• The current implementation behavior of resetting to the default value when sending null is the desired behavior, so I will send a PR so that the specification reflects the implementation behavior
• I will also check that the behavior is consistent in the implementation at any level of settings (top level, when setting eg typoTolerance to null, when setting minWordSizeForTypos to null, and also for faceting and pagination).

[curquiza]

Ok, thanks for the return @dureuill

I close this issue then!

[curquiza]

Sorry, I reopen because investigation needed before closing, sorry!

[dureuill]

• I will also check that the behavior is consistent in the implementation at any level of settings (top level, when setting eg typoTolerance to null, when setting minWordSizeForTypos to null, and also for faceting and pagination).

Checked the behavior. It is consistent at any level of settings, with a null value always resetting the value to the default.

We can close this task.