Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering tasks by indexUid returns global tasks having null as indexUid #2970

Closed
gmourier opened this issue Oct 26, 2022 · 0 comments · Fixed by #2982
Closed

Filtering tasks by indexUid returns global tasks having null as indexUid #2970

gmourier opened this issue Oct 26, 2022 · 0 comments · Fixed by #2982
Assignees
@loiclec
Labels
bug Something isn't working as expected v0.30.0 PRs/issues solved in v0.30.0 released on 2022-11-28
Milestone
v0.30.0

Comments

@gmourier
Copy link
Member

gmourier commented Oct 26, 2022 •
edited

Describe the bug

When filtering tasks by indexUid returns global tasks having null as indexUid while it shouldn't.

To Reproduce

  1. Swap indexes (e.g A and B)
  2. GET - /tasks?indexUid=A
  3. I get the indexSwap task in the response while I shouldn't since the indexUid is equal to null.

Expected behavior

I should only get tasks having an indexUid field being set to the given value, in that case A

Meilisearch version: v0.30.0-new-index-scheduler.beta.1
@gmourier gmourier added the bug Something isn't working as expected label Oct 26, 2022
@gmourier gmourier changed the title Filtering tasks with an indexUid returns global tasks having null as indexUid Filtering tasks by indexUid returns global tasks having null as indexUid Oct 26, 2022
@curquiza curquiza added this to the v0.30.0 milestone Oct 26, 2022
@loiclec loiclec self-assigned this Oct 26, 2022
This was referenced Oct 26, 2022
Merged
Merged
@curquiza curquiza linked a pull request Oct 27, 2022 that will close this issue
Adapt task queries to account for special index swap rules #2982
Merged
@bors bors bot closed this as completed in d16ea75 Oct 27, 2022
@meili-bot meili-bot added the v0.30.0 PRs/issues solved in v0.30.0 released on 2022-11-28 label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loiclec loiclec

Labels
bug Something isn't working as expected v0.30.0 PRs/issues solved in v0.30.0 released on 2022-11-28
Projects
None yet
Milestone
v0.30.0
Development

Successfully merging a pull request may close this issue.

Adapt task queries to account for special index swap rules meilisearch/meilisearch
4 participants
@gmourier @loiclec @curquiza @meili-bot